-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move Pinned Conversation Indicator #922
base: main
Are you sure you want to change the base?
Conversation
Moved Pinned Conversation indicator to left of title Removed Avatar Indicator Cleaned up style of indicator to be more reusable
Let's tag @covrter for visibility on these smaller visual adjustments going forward |
Great shout, thanks y'all |
Fine to do incrementally imo! |
<Text style={styles.text}>{title}</Text> | ||
<View style={styles.textContainer}> | ||
{showUnread && ( | ||
<View> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wrapping with this View?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as I did in the other one. I would just make sure that we do those because it's P0 IMO.
I'll get the base of the design-system next week for sure so we can start using it
Will hold onto this PR for a bit while we get the design system in place |
For whenever it's appropriate … let's
NBD, of course … I'll move this full screen into a dev ready frame soon but this element is ready for implementation anytime |
Moved Pinned Conversation indicator to left of title Removed Avatar Indicator
Cleaned up style of indicator to be more reusable
Closes #920