Adds ability to customize statusBarStyle #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation forces the .default status bar style when coach marks are displayed. This is inconvenient if the instructions are shown for a view who has a native status bar with light content. This commit addresses this issue and allows end user to customize the status bar style.
|
I'd appreciate if you could make this available via CocoaPods as soon as it is merged. I need this in my production code :) Had it in my fork of your repo previously, but want to move away from using my own forks. |
|
Great! Thanks for the work. As I said on #139, I'm going to merge this in |
Tonbouy
pushed a commit
to Tonbouy/Instructions
that referenced
this pull request
Nov 29, 2019
Adds ability to customize statusBarStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation forces the .default status bar style when coach marks are displayed. This is inconvenient if the instructions are shown for a view who has a native status bar with light content. This commit addresses this issue and allows end user to customize the status bar style.