-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Mac Catalyst #247
Merged
Merged
Fix for Mac Catalyst #247
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3cbe9bc
Fix for Mac Catalyst
0x0c bba190c
Fix tests
0x0c a36feb4
update .gitignore
0x0c 19dbd49
Add some files that are not ignored by .gitignore
0x0c e18915b
Update .gitignore
0x0c 99cb0d8
Update .gitignore
0x0c 1ed9e5b
Remove files that should be ignored.
0x0c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,7 +50,10 @@ internal class CustomCoachMarkBodyView: UIView, CoachMarkBodyView { | |
self.hintLabel.font = UIFont.systemFont(ofSize: 15.0) | ||
self.hintLabel.isScrollEnabled = false | ||
self.hintLabel.textAlignment = .justified | ||
#if targetEnvironment(macCatalyst) | ||
#else | ||
self.hintLabel.layoutManager.hyphenationFactor = 1.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 I'll do a sweep after this PR to remove them, I didn't realised it was deprecated in iOS 14 and unavailable in Catalyst. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got it! |
||
#endif | ||
self.hintLabel.isEditable = false | ||
|
||
self.nextButton.translatesAutoresizingMaskIntoConstraints = false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question about the snapshot tests and catalyst. Are they conditionally excluded because
iOSSnapshotTestCase
doesn't support catalyst? Did you run into issues?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not use
iOSSnapshotTestCase
on macOS as following error.I tried
carthage update --platform macOS
but I got an errorDependency "ios-snapshot-test-case" has no shared framework schemes for any of the platforms: Mac
.I think
iOSSnapshotTestCase
does not support macOS.