chore: Remove meta package #183
Conversation
|
Fair enough! Quick question for your consideration: is it worth it to move the Also, licenses and minimum versions are broken again :/ what should we do with that? |
|
The minimal-versions one is just the Github action runner problem #179, should resolve that one, you will see that for all PRs until that one has been merged. The Cargo deny one is my bad, the licenses were not checked properly because of a missing --workspace flag, precisely the reason behind this PR. But that exposes a different problem. I think merging the Dependabot updates might resolve that problem. 🤞 No need to merge until it becomes green.
I strongly recommend against it. The main problem of such a main package is that commands like cargo build will default to the main package instead of the workspace if one exists. I cannot count the amount of times I have run cargo check on the empty main package instead of the workspace, for example. |
This was needed by the zig build, but we have decided to use native compilation instead. Dropping this prevents errors where one only performs an action on the meta package instead of the workspace when --workspace is omitted.
DanielVoogsgerd
force-pushed
the
main-package
branch
from
576cdeb
to
36e63aa
Compare
|
OK, fair enough. Then we'll leave it as-is! |
Using --manifest path requires a main package for some (incorrect) reason. Just working around it for now by using pushd to change working directory
This is needed because the Cargo.toml in ctl
|
@Lut99 All green :) |
This was needed by the zig build, but we have decided to use native
compilation instead.
Dropping this prevents errors where one only performs an action on the
meta package instead of the workspace when --workspace is omitted.