Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 107 cancel scans from paused state #121

Merged
merged 21 commits into from
Nov 21, 2020

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 12, 2020

closes #107

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::unnecessary_unwrap
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #121 (3881789) into master (b48445f) will decrease coverage by 0.85%.
The diff coverage is 87.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   94.64%   93.79%   -0.86%     
==========================================
  Files          12       13       +1     
  Lines        2036     2208     +172     
==========================================
+ Hits         1927     2071     +144     
- Misses        109      137      +28     
Impacted Files Coverage Δ
src/main.rs 90.74% <ø> (ø)
src/scanner.rs 92.06% <70.00%> (-1.26%) ⬇️
src/scan_manager.rs 88.47% <88.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48445f...3881789. Read the comment docs.

@epi052 epi052 merged commit 3881789 into master Nov 21, 2020
@epi052 epi052 deleted the FEATURE-107-cancel-scans-from-paused-state branch November 21, 2020 14:22
@epi052 epi052 restored the FEATURE-107-cancel-scans-from-paused-state branch November 21, 2020 14:22
@epi052 epi052 deleted the FEATURE-107-cancel-scans-from-paused-state branch January 6, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant