Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #935
closes #926
closes #905
Landing a Pull Request (PR)
Long form explanations of most of the items below can be found in the CONTRIBUTING guide.
Branching checklist
Static analysis checks
cargo fmt
clippy
checks pass when runningcargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
Documentation
docs
, as needed. The docs live in a separate repository. Update the appropriate pages at the links below.Additional Tests