Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: diehlbw <36572844+diehlbw@users.noreply.github.com>
  • Loading branch information
gbowlin and diehlbw authored Oct 16, 2024
1 parent d3b29f9 commit 73e43dd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/seismometer/controls/explore.py
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ def update_plot(self, initial: bool = False):
self.update_plot_widget.disabled = True

def _try_generate_plot(self) -> Any:
"""Attempt to generate the plot. Displaying the error at HTML"""
"""Attempt to generate the plot. Displaying the error as HTML"""
try:
plot_args, plot_kwargs = self.generate_plot_args()
self.current_plot_code = self.generate_plot_code(plot_args, plot_kwargs)
Expand Down
2 changes: 1 addition & 1 deletion src/seismometer/report/fairness.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def get_fairness_icon(cls, ratio, limit: float = 0.25) -> "FairnessIcons":
If fairness ratio is 0.25 (25%) we want to show a warning if we are outside this range and
a critical warning if we are 2x outside this range
We are looking at 1 / (1 + limit) < allowed_ration < 1 + limit
We are looking at 1 / (1 + limit) < ratio < 1 + limit
For a limit of 0.25 we are looking at 0.80 < ratio < 1.25 (25% bigger, or 20% smaller)
Alternatively for a limit of 0.50 we are looking at 0.67 < ratio < 1.50 (50% bigger, or 33% smaller)
Expand Down

0 comments on commit 73e43dd

Please sign in to comment.