Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit 'invalid value' imputation #100

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

diehlbw
Copy link
Collaborator

@diehlbw diehlbw commented Oct 10, 2024

Overview

Several reports of confusion around -1 imputation for "invalid" predictions.
It only made complete sense in loose typed binary classifications, so was going to start causing issues with stricter datatypes as more variation is used.

Description of changes

Remove the actual -1 imputation (based on time comparisons)
Update the validation check to directly make the time comparison, specifically
Changed pdh.valid_event -> filtered frame to pdh.is_valid_event -> mask
Use pdh.is_valid_event more comprehensively instead of oneoff checks

Author Checklist

  • Linting passes; run early with pre-commit hook.
  • Tests added for new code and issue being fixed.
  • Added type annotations and full numpy-style docstrings for new methods.
  • Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

@diehlbw diehlbw merged commit da2110c into epic-open-source:main Oct 16, 2024
14 checks passed
@diehlbw diehlbw deleted the no_invalid_value branch October 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants