Remove explicit 'invalid value' imputation #100
Merged
+31
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Several reports of confusion around -1 imputation for "invalid" predictions.
It only made complete sense in loose typed binary classifications, so was going to start causing issues with stricter datatypes as more variation is used.
Description of changes
Remove the actual -1 imputation (based on time comparisons)
Update the validation check to directly make the time comparison, specifically
Changed pdh.valid_event -> filtered frame to pdh.is_valid_event -> mask
Use pdh.is_valid_event more comprehensively instead of oneoff checks
Author Checklist
changelog/ISSUE.TYPE.rst
files; see changelog/README.md.