-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Test suite for multiple enviroments #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehlbw
added
the
skip changelog
Add to allow skipping creation of a changelog entry
label
May 24, 2024
nhayes-rich
suggested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning on including the failing 3.12 pipeline still?
Removed, seems cleaner avoids the confusion of failing tasks |
nhayes-rich
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates CI for test coverage
Description of changes
Coverage should be done on base environment (py3.10 + linux) since there is no dependent branching
Test suite should run on:
3.12 has known install issue to resolve before adding - marked as experimental allowing failure
Using a runner matrix allowed for testing across environments and python versions without actually using nox. While this isn't easily reproducible on a single machine, it seems reasonable to forgo defining the nox sessions until we need more complexity. Testing multiple environments in a single python version might be reason to start using sessions (such as ensuring compatibility with multiple versions of pandas)
Author Checklist