Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Test suite for multiple enviroments #15

Merged
merged 8 commits into from
May 30, 2024

Conversation

diehlbw
Copy link
Collaborator

@diehlbw diehlbw commented May 24, 2024

Overview

Updates CI for test coverage

Description of changes

Coverage should be done on base environment (py3.10 + linux) since there is no dependent branching
Test suite should run on:

  • linux, macos, windows
  • python 3.10 and 3.11

3.12 has known install issue to resolve before adding - marked as experimental allowing failure

Using a runner matrix allowed for testing across environments and python versions without actually using nox. While this isn't easily reproducible on a single machine, it seems reasonable to forgo defining the nox sessions until we need more complexity. Testing multiple environments in a single python version might be reason to start using sessions (such as ensuring compatibility with multiple versions of pandas)

Author Checklist

@diehlbw diehlbw added the skip changelog Add to allow skipping creation of a changelog entry label May 24, 2024
@diehlbw diehlbw marked this pull request as ready for review May 24, 2024 21:22
@diehlbw diehlbw requested a review from a team as a code owner May 24, 2024 21:22
@diehlbw diehlbw marked this pull request as draft May 24, 2024 21:32
@diehlbw diehlbw marked this pull request as ready for review May 28, 2024 12:36
Copy link
Contributor

@nhayes-rich nhayes-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning on including the failing 3.12 pipeline still?

@diehlbw
Copy link
Collaborator Author

diehlbw commented May 29, 2024

Are we planning on including the failing 3.12 pipeline still?

Removed, seems cleaner avoids the confusion of failing tasks

@diehlbw diehlbw requested a review from nhayes-rich May 29, 2024 18:30
@diehlbw diehlbw merged commit 49b4815 into epic-open-source:main May 30, 2024
13 checks passed
@diehlbw diehlbw deleted the nox-tests branch May 30, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Add to allow skipping creation of a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants