Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove datatime columns for ydata-profiling update in 4.10 #88

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Remove datatime columns for ydata-profiling update in 4.10 #88

merged 6 commits into from
Sep 13, 2024

Conversation

gbowlin
Copy link
Contributor

@gbowlin gbowlin commented Sep 11, 2024 •
edited
Loading

Overview

Description of changes

Fixes issue with ydata-profiling 4.10.0 update that now enforces some data type restrictions.

Author Checklist

  • Linting passes; run early with pre-commit hook.
  • Tests added for new code and issue being fixed.
  • Added type annotations and full numpy-style docstrings for new methods.
  • Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

diehlbw
diehlbw reviewed Sep 12, 2024
View reviewed changes
src/seismometer/_api.py Outdated Show resolved Hide resolved
@gbowlin gbowlin marked this pull request as ready for review September 12, 2024 13:29
diehlbw
diehlbw requested changes Sep 12, 2024
View reviewed changes
src/seismometer/_api.py Outdated Show resolved Hide resolved
@gbowlin gbowlin merged commit 8b4bad0 into epic-open-source:main Sep 13, 2024
14 checks passed
@gbowlin gbowlin deleted the gbowlin/fix_ydata_profiling branch October 1, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehlbw diehlbw diehlbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbowlin @diehlbw