Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useBem hook #1887

Closed
RVitaly1978 opened this issue May 31, 2022 · 0 comments · Fixed by #1910
Closed

Update useBem hook #1887

RVitaly1978 opened this issue May 31, 2022 · 0 comments · Fixed by #1910
Assignees
Labels
feature Something useful to end user refactoring Prettify code without introducing new features

Comments

@RVitaly1978
Copy link
Member

RVitaly1978 commented May 31, 2022

Now we have:

const { createModifiersClasses } = useBem('va-input')
const computedClasses = createModifiersClasses(() => ({
  success: props.success,
  focused: props.focused,
  error: props.error,
}))

we want something like this

const computedClasses = useBem('va-input', () => pick(props, ['success', 'focused', 'error']))

After update this hook can be useful in useForm hook #1851 (review)

@RVitaly1978 RVitaly1978 added feature Something useful to end user refactoring Prettify code without introducing new features labels May 31, 2022
@aluarius aluarius self-assigned this Jun 2, 2022
aluarius added a commit to aluarius/vuestic-ui that referenced this issue Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something useful to end user refactoring Prettify code without introducing new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants