Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaSwitch @input event doesn't work #2074

Closed
asvae opened this issue Jul 11, 2022 · 3 comments · Fixed by #3907
Closed

VaSwitch @input event doesn't work #2074

asvae opened this issue Jul 11, 2022 · 3 comments · Fixed by #3907
Assignees
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. implementation Requires implementation v2: nice to have This will make Vuestic feel better

Comments

@asvae
Copy link
Member

asvae commented Jul 11, 2022

Vuestic-ui version: 1.4.6
We have it stated in the docs
image

but I tried in demo to

<va-switch
        v-model="value"
        @update:model-value="$vb.log('@update:model-value', value)"
        @input="$vb.log('input', $event)"
      />

and @input event was never getting triggered. It should return native event btw.

Bonus points

  • Consider adding change event (is it useful?). Maybe we only need @change?

So this issues is about native events. If switch doesn't have input event or something - you don't have to use it.

@asvae asvae added BUG Something isn't working good first issue Right issue if you're new to vuestic labels Jul 11, 2022
@asvae asvae changed the title Switch @input event doesn't work VaSwitch @input event doesn't work Jul 11, 2022
@m0ksem
Copy link
Collaborator

m0ksem commented Jul 11, 2022

Likely junk from vue2. Must be removed since we have update:model-value.

@arkmadj
Copy link
Contributor

arkmadj commented Jul 11, 2022

@m0ksem Can I work on this issue?

@asvae
Copy link
Member Author

asvae commented Jul 11, 2022

@m0ksem We need to pass native event somehow, and we don't achieve this in @update:model-value.

So I think we want to pass-through native events with native events for all form components.

@asvae asvae added team discussion Feedback wanted and removed good first issue Right issue if you're new to vuestic labels Jul 11, 2022
@asvae asvae added implementation Requires implementation and removed team discussion Feedback wanted labels Jul 28, 2022
@m0ksem m0ksem added d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v2: nice to have This will make Vuestic feel better labels Feb 22, 2023
@m0ksem m0ksem self-assigned this Sep 25, 2023
m0ksem added a commit to m0ksem/vuestic-ui that referenced this issue Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. implementation Requires implementation v2: nice to have This will make Vuestic feel better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants