Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt 3: open modal not disabling document (body) overflow when use @vuestic/nuxt module #2968

Closed
1isten opened this issue Feb 14, 2023 · 0 comments · Fixed by #2975
Closed
Assignees
Labels
BUG Something isn't working external Reported by external contributor and handled with priority

Comments

@1isten
Copy link

1isten commented Feb 14, 2023

Vuestic-ui version: 1.5.3

Steps to reproduce
nuxt.config.ts

export default defineNuxtConfig({
  modules: [
    '@vuestic/nuxt'
  ],

  vuestic: {
    config: {
      // Vuestic config here
    }
  },
})

app.vue

<template>
  <div>
    <va-button @click="showModal = !showModal">Show modal (default)</va-button>
    <va-modal v-model="showModal" :message="popupMessage" title="Overview" :mobile-fullscreen="false" blur />
    <pre>{{ showModal }}</pre>

    <p v-for="n in 100" :key="n">{{ n }}</p>
  </div>
</template>

<script setup>
const showModal = ref(false);
const popupMessage = `Lorem ipsum dolor sit amet, consectetur adipisicing elit. Alias animi aspernatur atque blanditiis, consequatur corporis deleniti exercitationem expedita facilis fugit inventore laborum nam nobis odit, quae quas repudiandae vitae voluptates.`;
</script>

What is the expected behavior?
When modal is opened, the background content overflow scroll should be disabled

What is the current behavior?
document overflow is still scrollable
image

@1isten 1isten added BUG Something isn't working external Reported by external contributor and handled with priority labels Feb 14, 2023
@1isten 1isten changed the title Nuxt 3: open modal open not disabling document (body) overflow when use @vuestic/nuxt module Nuxt 3: open modal not disabling document (body) overflow when use @vuestic/nuxt module Feb 14, 2023
@aluarius aluarius self-assigned this Feb 15, 2023
aluarius added a commit to aluarius/vuestic-ui that referenced this issue Feb 15, 2023
m0ksem pushed a commit that referenced this issue Feb 17, 2023
… scroll (#2975)

* [#2968] fix-body prop for va-modal to prevent document scroll

* refactor: review suggestions

* feat: new implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working external Reported by external contributor and handled with priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants