Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No margins in counter with buttons in the slots #3397

Closed
EugenGedroyc opened this issue May 2, 2023 · 1 comment · Fixed by #3441
Closed

No margins in counter with buttons in the slots #3397

EugenGedroyc opened this issue May 2, 2023 · 1 comment · Fixed by #3441
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better

Comments

@EugenGedroyc
Copy link
Contributor

EugenGedroyc commented May 2, 2023 •
edited
Loading

Vuestic-ui version: 1.6.4

Steps to reproduce
create counter like this:
#3161
and this bug appeared in 1.6.4 after fixes in this issue

.va-input-wrapper__field > *,
.va-input-wrapper__container > * {
margin-right: 0;
}

What is the expected behavior?
margins between input and buttons

What is the current behavior?
no margins, but ONLY in demo in styles the margins = 4px :
https://ui.vuestic.dev/ru/ui-elements/counter

Other information
I'm ready to fix it.
@EugenGedroyc EugenGedroyc added the BUG Something isn't working label May 2, 2023
@asvae asvae added v2: nice to have This will make Vuestic feel better d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic and removed v2: nice to have This will make Vuestic feel better labels May 15, 2023
@asvae
Copy link
Member

asvae commented May 15, 2023

@EugenGedroyc would be awesome if you do :)

@RVitaly1978 RVitaly1978 moved this from Backlog to In Progress in Vuestic Dashboard May 26, 2023
@RVitaly1978 RVitaly1978 linked a pull request May 26, 2023 that will close this issue
[#3397] Added the margin to the counter #3441
Merged
4 tasks
m0ksem pushed a commit that referenced this issue May 26, 2023
@sathiyaIbe
[#3397] Added the margin to the counter (#3441)
92adcff 
* issues: #3397 Added the margin to the counter

* fix : #3397 chnages are made

* removed the empty lines of 398, 399, 400, 401, 402, 403 and 408.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Vuestic Dashboard May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better
Projects
Vuestic Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3397] Added the margin to the counter
2 participants
@asvae @EugenGedroyc