Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish: va-form #3765

Open
Tracked by #3705
asvae opened this issue Aug 29, 2023 · 0 comments
Open
Tracked by #3705

Polish: va-form #3765

asvae opened this issue Aug 29, 2023 · 0 comments
Labels
d3: medium No cheats. Monsters a bit faster. good first issue Right issue if you're new to vuestic storybook Relates to storybook v3: wish to have This is something user want, but can live without it

Comments

@asvae
Copy link
Member

asvae commented Aug 29, 2023

Stories

  • We have a couple of stories that are not done properly.
image
  • Most of the form stories operate with input, but in truth, they should operate on some generic form element, which we should probably mock.
    To solve this problem we would likely have to do something like this:
    • form stories would focus on form element mock
    • every form element would have Form story, that covers all form cases. We probably need a wrapper, which would be reused for all form elements.
    • Then we'll have FormFormElementInteractions.stories.ts file, which will just display all form element form stories on a single page for convenience.
  • We're missing stories for form-data, hideLoading and tag.
  • We forgot VaFormVuelidate story. It's done in a separate file and is not connected at all. It supposedly should showcase library usage.
@asvae asvae mentioned this issue Aug 29, 2023
77 tasks
@asvae asvae added storybook Relates to storybook v3: wish to have This is something user want, but can live without it d3: medium No cheats. Monsters a bit faster. labels Aug 29, 2023
@asvae asvae added the good first issue Right issue if you're new to vuestic label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d3: medium No cheats. Monsters a bit faster. good first issue Right issue if you're new to vuestic storybook Relates to storybook v3: wish to have This is something user want, but can live without it
Projects
None yet
Development

No branches or pull requests

1 participant