Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories rework: VaForm #3699

Merged
merged 9 commits into from
Aug 29, 2023
Merged

Stories rework: VaForm #3699

merged 9 commits into from
Aug 29, 2023

Conversation

Roman4437
Copy link
Collaborator

@Roman4437 Roman4437 commented Aug 16, 2023 •
edited by asvae
Loading

Form stories

Moved leftovers to #3765

@Roman4437 Roman4437 changed the title added form stories VaForm stories Aug 16, 2023
asvae
asvae requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is mostly fine, but stories are extremely bloated. We can cut about 50% of code without losing quality.

packages/ui/src/components/va-form/VaForm.stories.ts Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-form/VaForm.stories.ts Show resolved Hide resolved
@Roman4437 Roman4437 requested a review from asvae August 17, 2023 23:09
asvae
asvae requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polish mostly. We're close.

@Roman4437 Roman4437 requested a review from asvae August 18, 2023 13:07
@asvae asvae mentioned this pull request Aug 18, 2023
Open
75 tasks
@asvae asvae changed the title VaForm stories Stories rework: VaForm Aug 18, 2023
@Roman4437 Roman4437 requested review from asvae and m0ksem August 19, 2023 10:58
asvae
asvae requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to decide what to do with validation lib and form interaction stories. These are not finished.

@Roman4437 Roman4437 requested a review from asvae August 22, 2023 17:24
@asvae asvae merged commit 8f2c8db into epicmaxco:develop Aug 29, 2023
m0ksem pushed a commit that referenced this pull request Sep 12, 2023
@Roman4437 @asvae @m0ksem
Stories rework: VaForm (#3699)
8648f99 
* added form stories

* form fix

* form fix

* form polish

* fix

* va-form fix

* va-form fix

* minor tweaks

---------

Co-authored-by: Yauheni Prakopchyk <yauheni.prakopchyk@epicmax.co>
@Roman4437 Roman4437 deleted the va-form branch September 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem Awaiting requested review from m0ksem

@asvae asvae Awaiting requested review from asvae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roman4437 @asvae @m0ksem