Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaInput: Inner label makes the input 2px bigger #3950

Closed
asbermudez opened this issue Oct 9, 2023 · 0 comments · Fixed by #4203
Closed

VaInput: Inner label makes the input 2px bigger #3950

asbermudez opened this issue Oct 9, 2023 · 0 comments · Fixed by #4203
Labels
BUG Something isn't working

Comments

@asbermudez
Copy link
Contributor

Vuestic-ui version: 1.8.1

Steps to reproduce
Check documentation page:

Screenshot 2023-10-09 at 15 38 03

What is the expected behavior?
Should have the same height as non-inner label inputs

What is the current behavior?
It has 2px more, making it 38px height instead of 36px

Other information
@asbermudez asbermudez added the BUG Something isn't working label Oct 9, 2023
gweesin added a commit to gweesin/vuestic-ui that referenced this issue Apr 3, 2024
@gweesin
fix(VaInputWrapper): fix the height inconsistency between inner label…
612698e 
… and outer label modes' inputs(epicmaxco#3950)
@gweesin gweesin mentioned this issue Apr 3, 2024
Merged
4 tasks
m0ksem added a commit that referenced this issue Apr 30, 2024
@gweesin @m0ksem
fix(VaInputWrapper): fix inner label height(#3950) (#4203)
6d3d8e9 
* fix(VaInputWrapper): fix the height inconsistency between inner label and outer label modes' inputs(#3950)

* chore(input): prevent extra specific selector in inner-labeled input height

---------

Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Vuestic Dashboard Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something isn't working
Projects
Vuestic Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VaInputWrapper): fix inner label height(#3950) gweesin/vuestic-ui
1 participant
@asbermudez