Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded row invalid markup #4241

Closed
mr-sanders opened this issue Apr 26, 2024 · 0 comments · Fixed by #4257
Closed

Expanded row invalid markup #4241

mr-sanders opened this issue Apr 26, 2024 · 0 comments · Fixed by #4257
Assignees
@Fsss126
Labels
BUG Something isn't working

Comments

@mr-sanders
Copy link

Vuestic-ui version: 1.9.8

Description

When a row is expanded, the <td> tag is not enclosed within a <tr> tag. This disrupts basic accessibility in VoiceOver, making the cell content invisible to screen readers.

Current Behavior

The <td> tag is unwrapped in the table's <tbody>.

Expected Behavior

The <td> tag should be enclosed within a <tr> tag.

Reproduction Steps

  1. Open https://ui.vuestic.dev/ui-elements/data-table#expandable-rows.
  2. Expand any row.
  3. Check the markup of the expanded row in Developer Tools.
@mr-sanders mr-sanders added the BUG Something isn't working label Apr 26, 2024
Fsss126 added a commit to Fsss126/vuestic-ui that referenced this issue May 6, 2024
@Fsss126
Wrap expanded row in tr epicmaxco#4241
d409c8a
@Fsss126 Fsss126 mentioned this issue May 6, 2024
Merged
4 tasks
m0ksem pushed a commit that referenced this issue May 7, 2024
@Fsss126
Wrap expanded row in tr (#4241) (#4257)
2ba7668
@github-project-automation github-project-automation bot moved this from Backlog to Done in Vuestic Dashboard May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fsss126 Fsss126

Labels
BUG Something isn't working
Projects
Vuestic Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap expanded row in tr (#4241) Fsss126/vuestic-ui
2 participants
@mr-sanders @Fsss126