[#1838] va-radio tab selection fix, accessibility updates #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVitaly1978
approved these changes
May 23, 2022
Derranion
approved these changes
May 24, 2022
rustem-nasyrov
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #1838
Description
VaRadioTabnavigation was broken - now it's fixed. Few minor related accessibility updates.P.S. Safari tab navigation -
Opt+Tab(https://stackoverflow.com/questions/1848390/safari-ignoring-tabindex). Can think about global service to replace this behaviour (not sure if we need to).Types of changes