Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload undo examples #1977

Merged
merged 3 commits into from
Jun 22, 2022
Merged

File upload undo examples #1977

merged 3 commits into from
Jun 22, 2022

Conversation

rustem-nasyrov
Copy link
Collaborator

Close #1786

image

Description

Added examples and translations of the undoing the removing action usage.

Types of changes

  • New feature (non-breaking change which adds functionality)

@rustem-nasyrov rustem-nasyrov self-assigned this Jun 21, 2022
@rustem-nasyrov rustem-nasyrov added the docs packages/docs label Jun 21, 2022
m0ksem
m0ksem approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a progress here.
image

So this line is slightly decreasing as undo time gone. Would be nice if you implement it with CSS variable and CSS keyframes :)

@rustem-nasyrov
Copy link
Collaborator Author

Would be nice to have a progress here. image

So this line is slightly decreasing as undo time gone. Would be nice if you implement it with CSS variable and CSS keyframes :)

Okay, I'll do it. :)

@rustem-nasyrov rustem-nasyrov mentioned this pull request Jun 22, 2022
Closed
@rustem-nasyrov rustem-nasyrov merged commit 0142e81 into epicmaxco:develop Jun 22, 2022
@rustem-nasyrov rustem-nasyrov deleted the feat/file-upload-undo-examples branch June 22, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluarius aluarius aluarius approved these changes

@m0ksem m0ksem m0ksem approved these changes

@RVitaly1978 RVitaly1978 Awaiting requested review from RVitaly1978

Assignees

@rustem-nasyrov rustem-nasyrov

Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs example about VaFileUpload
3 participants
@rustem-nasyrov @m0ksem @aluarius