-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/typography #2064
docs/typography #2064
Conversation
It still doesn't look perfect. Any thoughts how we can improve these docs in general and made them easier to read? |
@m0ksem, maybe we should add a little playground to demonstrate available utility classes? |
I would've called these helpers, not utils. maybe splitting examples into different blocks would make things easier to understand? Also see bootstrap. |
@xx13 we need to increase text saturation for the blockquotes, because it's barely visible, any suggestions? |
Yeah. This thing looks inappropriate 😟 Same with buttons in demo navigation below. They are not accessible. |
it should have |
packages/docs/src/page-configs/styles/typography/examples/textUtils.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :).
New docs typogpragy page
Demo with borders approved by @xx13. It allows user easily find correct code example, instead of searching correct class in long example code. Title heading can also be visible now. It was hard to find it in headers mess before.
Removed useless headings, just watch and copy example!
Added text helpers docs.
Text helpers must have an interactive example I guess, but we are good to go for now.
New demo borders
For typography it was hard to see where is header and header demo. So I decided to make border around demos like 100% other Frameworks have. It also will fit in interactive playground, which we want to implement later.
Headers margins mess
We had unlogical margins set to our typography headers to satisfy docs needs. I separated docs styles and our typography module styles. Also, now headers with typography module and va content component looks the same. All values took from Figma.
Docs headers margins
In #1479 I think what we wanted is to remove big space between title and subtitle. Made this. First subtitle was without margins before.
closes #1175