Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/typography #2064

Merged
merged 14 commits into from
Jul 21, 2022
Merged

docs/typography #2064

merged 14 commits into from
Jul 21, 2022

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Jul 8, 2022

New docs typogpragy page

image
image

Demo with borders approved by @xx13. It allows user easily find correct code example, instead of searching correct class in long example code. Title heading can also be visible now. It was hard to find it in headers mess before.

Removed useless headings, just watch and copy example!
image

Added text helpers docs.
image
Text helpers must have an interactive example I guess, but we are good to go for now.

New demo borders

image

For typography it was hard to see where is header and header demo. So I decided to make border around demos like 100% other Frameworks have. It also will fit in interactive playground, which we want to implement later.

Headers margins mess

We had unlogical margins set to our typography headers to satisfy docs needs. I separated docs styles and our typography module styles. Also, now headers with typography module and va content component looks the same. All values took from Figma.

Docs headers margins

In #1479 I think what we wanted is to remove big space between title and subtitle. Made this. First subtitle was without margins before.

closes #1175

@m0ksem m0ksem marked this pull request as ready for review July 8, 2022 14:26
@m0ksem m0ksem requested a review from rustem-nasyrov July 8, 2022 14:26
@m0ksem m0ksem added the docs packages/docs label Jul 8, 2022
@m0ksem
Copy link
Collaborator Author

m0ksem commented Jul 8, 2022

It still doesn't look perfect. Any thoughts how we can improve these docs in general and made them easier to read?

@m0ksem m0ksem self-assigned this Jul 8, 2022
@rustem-nasyrov
Copy link
Collaborator

@m0ksem, maybe we should add a little playground to demonstrate available utility classes?

@m0ksem m0ksem marked this pull request as draft July 9, 2022 16:30
@m0ksem m0ksem added this to the 1.4.7 (current) milestone Jul 10, 2022
@asvae
Copy link
Member

asvae commented Jul 11, 2022

I would've called these helpers, not utils.

maybe splitting examples into different blocks would make things easier to understand?
I.e. "Text alighnment", "Text transform".

Also see bootstrap.

@m0ksem m0ksem modified the milestones: 1.4.7, 1.4.8 (current) Jul 14, 2022
@m0ksem m0ksem requested a review from asvae July 15, 2022 17:16
@m0ksem m0ksem marked this pull request as ready for review July 15, 2022 17:26
@m0ksem m0ksem requested a review from aluarius July 15, 2022 17:28
@rustem-nasyrov
Copy link
Collaborator

@xx13 we need to increase text saturation for the blockquotes, because it's barely visible, any suggestions?
image

@m0ksem
Copy link
Collaborator Author

m0ksem commented Jul 19, 2022

@xx13 we need to increase text saturation for the blockquotes, because it's barely visible, any suggestions? image

Yeah. This thing looks inappropriate 😟

Same with buttons in demo navigation below. They are not accessible.

@xx13
Copy link

xx13 commented Jul 19, 2022

it should have secondary colour which is #767C88 in designs. if we want to have secondary as primary with opacity, I'll get you % value in that case.

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :).

@m0ksem m0ksem changed the title Docs/typography utils docs/typography Jul 21, 2022
@m0ksem m0ksem merged commit 195d34f into epicmaxco:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs packages/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography detailed docs
6 participants