Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor docs fixes #2716

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Minor docs fixes #2716

merged 2 commits into from
Nov 28, 2022

Conversation

aluarius
Copy link
Contributor

Closes: #2160
Closes: #2369
Closes: #2679
Closes: #2702
Closes: #2352

Description

Minor fixes and updates related to issues above.

@xx13

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@aluarius aluarius self-assigned this Nov 23, 2022
rustem-nasyrov
rustem-nasyrov requested changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, just one more thing, in Safari iOS (Chrome I guess too) the last item in the sidebar is cut.

Screenshot image

@aluarius
Copy link
Contributor Author

aluarius commented Nov 23, 2022 •
edited
Loading

Excellent, just one more thing, in Safari iOS (Chrome I guess too) the last item in the sidebar is cut.

I've calculated this (4 rem) value for Chrome, for Safari it should be larger (because address line is also at screens' bottom). Will update tomorrow, great u've mentioned it!

asvae
asvae approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge it to have new changes in docs. If there is something still missing - please open another PR 😋

rustem-nasyrov
rustem-nasyrov approved these changes Nov 26, 2022
View reviewed changes
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@aluarius aluarius merged commit cd42a5d into epicmaxco:develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

@asvae asvae asvae approved these changes

@xx13 xx13 Awaiting requested review from xx13

@Azgiliat Azgiliat Awaiting requested review from Azgiliat

Assignees

@aluarius aluarius

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aluarius @asvae @rustem-nasyrov