-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tree view improvements #2840
Feat/tree view improvements #2840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me. Have you found a guide for keyboard navigation somewhere? I would like to select node with space, because for now I need to select checkbox with tab and then go back.
If you used some guide, for example, w3c, how about mentioning it in docs?
What you think about this scenario:
I've used this guide from MDN. |
So let's use space as described here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tree_role#multi-select_keyboard_interactions |
packages/ui/src/components/va-tree-view/hooks/useTreeKeyboardNavigation.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-tree-view/hooks/useTreeKeyboardNavigation.ts
Show resolved
Hide resolved
packages/ui/src/components/va-tree-view/hooks/useTreeKeyboardNavigation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, i've done with code. Next i'll leave a few suggestions related to fucntionality.
I give up :) All specifications say that enter-space should select node. But for me it looks unobvious. |
Close #2639
Close #2638
Close #2545
Close #2661
Description
Types of changes