Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: bundle script start rework #2848

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Refactor: bundle script start rework #2848

merged 2 commits into from
Jan 11, 2023

Conversation

aluarius
Copy link
Contributor

@aluarius aluarius commented Jan 6, 2023

Related to the #2781

Description

  • all generated files excluded from git;
  • added script arguments handles;
  • common refactoring.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@aluarius aluarius requested a review from m0ksem January 6, 2023 09:02
@aluarius aluarius self-assigned this Jan 6, 2023
m0ksem
m0ksem approved these changes Jan 11, 2023
View reviewed changes
packages/sandbox/scripts/bundle-analysis.ts Outdated Show resolved Hide resolved
packages/sandbox/scripts/bundle-analysis.ts Show resolved Hide resolved
@m0ksem m0ksem merged commit e787db8 into epicmaxco:develop Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees

@aluarius aluarius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aluarius @m0ksem