Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/fallback component #2867

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Feat/fallback component #2867

merged 8 commits into from
Jan 18, 2023

Conversation

rustem-nasyrov
Copy link
Collaborator

Partially #2663

Description

  • Reworked fallback behavior and created separate component for it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@rustem-nasyrov rustem-nasyrov added the component Is a new component or part of existing one label Jan 17, 2023
@rustem-nasyrov rustem-nasyrov self-assigned this Jan 17, 2023
@rustem-nasyrov
Copy link
Collaborator Author

@aluarius, @m0ksem, please take a look at the preset and vuestic configuration behavior.

m0ksem
m0ksem approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, these props are good for global configuration, but if user wants to configure some specific image to have a fallback it is much easier to provide a slot. But it is not a big deal.

packages/ui/src/components/va-avatar/VaAvatar.vue Show resolved Hide resolved
packages/ui/src/components/va-avatar/VaAvatar.vue Outdated Show resolved Hide resolved
@rustem-nasyrov rustem-nasyrov marked this pull request as ready for review January 17, 2023 13:32
@rustem-nasyrov rustem-nasyrov requested a review from m0ksem January 17, 2023 13:32
@rustem-nasyrov rustem-nasyrov changed the title Feat/use fallback composable Feat/fallback component Jan 17, 2023
aluarius
aluarius approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@aluarius aluarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't make a documentation page for this component?

@rustem-nasyrov
Copy link
Collaborator Author

We won't make a documentation page for this component?

No, it's not that necessary component.

@rustem-nasyrov rustem-nasyrov merged commit ebd7eca into epicmaxco:develop Jan 18, 2023
@rustem-nasyrov rustem-nasyrov deleted the feat/use-fallback-composable branch January 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluarius aluarius aluarius approved these changes

@m0ksem m0ksem Awaiting requested review from m0ksem

Assignees

@rustem-nasyrov rustem-nasyrov

Labels
component Is a new component or part of existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustem-nasyrov @m0ksem @aluarius