[#2870] VaImage intersectioning
#2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/docs/src/page-configs/ui-elements/image/examples/Contain.vue # packages/docs/src/page-configs/ui-elements/image/examples/Default.vue # packages/docs/src/page-configs/ui-elements/image/examples/DefaultSlot.vue # packages/docs/src/page-configs/ui-elements/image/examples/ErrorSlot.vue # packages/docs/src/page-configs/ui-elements/image/examples/LoaderSlot.vue # packages/docs/src/page-configs/ui-elements/image/examples/Ratio.vue
aluarius
changed the title
VaImage intersectioning
# Conflicts: # packages/docs/src/locales/en/en.json # packages/docs/src/locales/ru/ru.json
…rsectioning # Conflicts: # packages/docs/src/locales/en/en.json # packages/docs/src/locales/ru/ru.json # packages/ui/src/components/va-image/VaImage.vue
aluarius
requested review from
rustem-nasyrov,
m0ksem,
asvae and
LighthouseKeeperYN
rustem-nasyrov
requested changes
Jan 27, 2023
|
What's wrong with |
Answered in Slack. |
Fixed. Had some troubles to make it work well with SSR. |
rustem-nasyrov
approved these changes
Jan 27, 2023
m0ksem
approved these changes
Jan 30, 2023
|
@aluarius, please double check how it works with nuxt in sandbox and merge it. |
|
I've tested it first of all in Nuxt :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked by #2868
Closes: #2870
Description
Types of changes