-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implement stepper component #2906
feature: implement stepper component #2906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Have you used any references while you implemented this component?
I have a concerns about using templates instead of creating va-step-item
component (or something similar).
- We missing finish button on the last step.
- Vertical example looks odd.
packages/docs/src/page-configs/ui-elements/stepper/examples/Default.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/page-configs/ui-elements/stepper/examples/Custom.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/page-configs/ui-elements/stepper/examples/Default.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/page-configs/ui-elements/stepper/examples/Custom.vue
Outdated
Show resolved
Hide resolved
Two way: <VaStepper>
<MyStepOne #step-0 />
<MyStepTwo #step-1 />
<MyStepThree #step-2 />
</VaStepper> <VaStepper>
<VaStepItem>
<MyStepOne />
</VaStepItem>
<VaStepItem>
<MyStepTwo />
</VaStepItem>
<VaStepItem>
<MyStepThree />
</VaStepItem>
</VaStepper> |
Too difficult at this point. |
packages/docs/src/page-configs/ui-elements/stepper/examples/Custom.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/page-configs/ui-elements/stepper/examples/Custom.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component should be accessible: keyboard navigation + aria attributes.
https://docs.telerik.com/kendo-ui/controls/navigation/stepper/accessibility/keyboard-navigation
https://stackoverflow.com/questions/52932018/making-a-step-progress-indicator-accessible-for-screen-readers
close #2245
Types of changes