Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional strong typing to DataTableColumn #2915

Merged
merged 1 commit into from
Feb 10, 2023
Merged

feat: add optional strong typing to DataTableColumn #2915

merged 1 commit into from
Feb 10, 2023

Conversation

asbermudez
Copy link
Contributor

Description

Added generic to DataTableColumn to allow for strongly-typed keys when using the interface.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

m0ksem
m0ksem approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m0ksem m0ksem merged commit 4e0b85c into epicmaxco:develop Feb 10, 2023
@m0ksem m0ksem added the types label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbermudez @m0ksem