fix: add CleaveOptions type to mask prop to match real use #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m0ksem sorry, I accidentally closed it by removing my fork... |
|
Hi, @asbermudez. I changed a bit this PR. Can you check if it solves your particular issue using VaInput.demo.vue? I tried with phone and it's OK. Want to double-check this. |
m0ksem
approved these changes
Feb 13, 2023
|
@m0ksem Works like a charm as far as I can see :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mask property from the useCleave() hook had the missing CleaveOptions type which is a valid input type for it
Types of changes