Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ag grid #2973

Merged
merged 22 commits into from
Feb 17, 2023
Merged

Feat/ag grid #2973

merged 22 commits into from
Feb 17, 2023

Conversation

rustem-nasyrov
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov commented Feb 15, 2023 •
edited
Loading

Close #2992
Close #2300
Close #1200

image

Description

  • Added latest ag-grid version support.
  • Added css build for non-scss users.
  • Added demo file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@rustem-nasyrov
fix: path to the ag-grid mixins
3e34d25
@rustem-nasyrov
refactor: move to the styles to the styles folder; remove index.js
5a94022
@rustem-nasyrov
feat: use vite and rollup to build styles
ffa4436
@rustem-nasyrov
feat: install latest ag-grid package
8fa55e4
@rustem-nasyrov
fix: replace deprecated sass function with css variables
1e6795c
@rustem-nasyrov
feat: partially migrate to the new api
d3d2718
@rustem-nasyrov
fix: remove redundant colors, fix striped modifier
a495356
@rustem-nasyrov
Merge branch 'develop' into feat/ag-grid
7b65c43
@rustem-nasyrov
Merge branch 'develop' into feat/ag-grid
7f5bb83
@rustem-nasyrov
feat: add hoverable colors; refactor: remove comments
5e78639
@rustem-nasyrov
fix: restored header height and fixed font-size
7d71d94
@rustem-nasyrov
feat: add SCSS variables, refactor to the new variables
25aff07
@rustem-nasyrov
feat: migrate from vite to the rollup
4dd5d8a
@rustem-nasyrov
feat: add demo examples
c8b51c1
@rustem-nasyrov
refactor: remove old scss
108f51a
@rustem-nasyrov
feat: update docs examples
eddb019
@rustem-nasyrov
Merge branch 'develop' into feat/ag-grid
2492ba4
@rustem-nasyrov rustem-nasyrov self-assigned this Feb 15, 2023
m0ksem
m0ksem approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated docs and package.json exports.

@rustem-nasyrov rustem-nasyrov merged commit 2a6b5e6 into epicmaxco:develop Feb 17, 2023
@rustem-nasyrov rustem-nasyrov deleted the feat/ag-grid branch February 17, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

@asvae asvae Awaiting requested review from asvae

@aluarius aluarius Awaiting requested review from aluarius

Assignees

@rustem-nasyrov rustem-nasyrov

Labels
ag-grid packages/ag-grid breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing AG Grid page Ag-grid theme extension should use css instead of scss Bring back ag-grid demos
2 participants
@rustem-nasyrov @m0ksem