Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2989] [#2990] Tailwind & VaAspectRatio docs pages, related bugfix #3000

Merged
merged 4 commits into from
Feb 17, 2023
Merged

[#2989] [#2990] Tailwind & VaAspectRatio docs pages, related bugfix #3000

merged 4 commits into from
Feb 17, 2023

Conversation

aluarius
Copy link
Contributor

Closes: #2989
Closes: #2990

Description

  • Tailwind docs page;
  • VaAspectRatio docs page;
  • VaAspectRatio added to @vuestic/nuxt components list;
  • Vuestic UI build type error fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@aluarius aluarius self-assigned this Feb 16, 2023
@aluarius aluarius changed the title [#2989] [#2990] Tailwind & VaAspactRatio docs pages, related bugfix [#2989] [#2990] Tailwind & VaAspectRatio docs pages, related bugfix Feb 16, 2023
m0ksem
m0ksem requested changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues

packages/ui/src/components/va-select/components/VaSelectContent/VaSelectContent.vue Outdated Show resolved Hide resolved
packages/docs/page-config/ui-elements/aspect-ratio/index.ts Outdated Show resolved Hide resolved
packages/docs/page-config/ui-elements/aspect-ratio/index.ts Outdated Show resolved Hide resolved
packages/docs/page-config/styles/tailwind/code/configuringFull.ts Show resolved Hide resolved
@m0ksem m0ksem mentioned this pull request Feb 16, 2023
Open
m0ksem
m0ksem requested changes Feb 16, 2023
View reviewed changes
packages/docs/locales/en.json Outdated Show resolved Hide resolved
@m0ksem
Copy link
Collaborator

m0ksem commented Feb 16, 2023 •
edited
Loading

And I would reorder styles nav menu:

  • Colors
  • CSS Variables
  • Typography
  • GrId (Make alert in grid and say that we recommend use Tailwind)
  • Tailwind Integration
  • Smart Helpers
  • CSS reset (Make alert that we will remove it, because components work great without reset).

@aluarius
refactor: review suggestions
a8db792
@aluarius
Merge branch 'develop' into fix/2990-2989-docs-bugs
633aa71 
# Conflicts:
#	packages/ui/src/components/va-select/components/VaSelectContent/VaSelectContent.vue
@aluarius
refactor: review suggestions
010c76c
@aluarius aluarius requested a review from m0ksem February 17, 2023 07:45
@m0ksem m0ksem merged commit 2d4712b into epicmaxco:develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

@m0ksem m0ksem m0ksem approved these changes

Assignees

@aluarius aluarius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aspect Ration missing page Tailwind missing page
3 participants
@aluarius @m0ksem @rustem-nasyrov