Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3024] nuxt-link is now available in vuestic #3043

Merged
merged 2 commits into from
Feb 27, 2023
Merged

[#3024] nuxt-link is now available in vuestic #3043

merged 2 commits into from
Feb 27, 2023

Conversation

aluarius
Copy link
Contributor

Closes: #3024

Description

  • now internal links in nuxt 3 renders via nuxt-link, not router link.

Types of changes

  • New feature (non-breaking change which adds functionality)

@aluarius aluarius self-assigned this Feb 21, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Feb 21, 2023

I'm not sure if it is must be in GlobalConfig. I'd better make it hidden with provide/inject. What do you think?

@aluarius aluarius mentioned this pull request Feb 22, 2023
Open
m0ksem
m0ksem approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We gonna need up vuestic-ui version to 1.6.2. Maybe add TODO: in code so I'll not forget about it.

@aluarius aluarius merged commit a3ff983 into epicmaxco:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

@rustem-nasyrov rustem-nasyrov Awaiting requested review from rustem-nasyrov

Assignees

@aluarius aluarius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use NuxtLink using resolveComponent in useRouterLink composable
2 participants
@aluarius @m0ksem