feat: migration guide #3045
Merged
feat: migration guide #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
requested changes
Feb 22, 2023
| "image": "Component was reworked. Suggest to check all places of usage.", | ||
| "extensions": "Extensions", | ||
| "aggrid_0": "Ag Grid", | ||
| "aggrid_1": "Removed SCSS mixins for Vuestic UI theme customization.", |
There was a problem hiding this comment.
They must be available with @vuestic/ag-grid/scss import. @rustem-nasyrov?
There was a problem hiding this comment.
This phrase was approved by him.
packages/docs/locales/en.json
Outdated
| "extensions": "Extensions", | ||
| "aggrid_0": "Ag Grid", | ||
| "aggrid_1": "Removed SCSS mixins for Vuestic UI theme customization.", | ||
| "tailwind": "Added {'@vuestic/tailwind'} package for config syncing between Vuestic UI and Tailwind CSS." |
There was a problem hiding this comment.
"Deprecated grid. Use Tailwind instead. "
It is migration guide, not release log.
There was a problem hiding this comment.
I'll change, but imo migration guide should contain something like do it, or you'll face issues in this version. Unlikely grid system in 1.6.0.
m0ksem
approved these changes
Feb 24, 2023
m0ksem
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes