Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expandable row #3054

Merged
merged 8 commits into from
Mar 1, 2023

Conversation

LighthouseKeeperYN
Copy link
Contributor

@LighthouseKeeperYN LighthouseKeeperYN commented Feb 23, 2023

close #2837

Adds expandable row for data table.

Breaking changes: cell slot bindings were changed from cell to { cell, row }. row property is necessary to access expandable row trigger method.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

image

@LighthouseKeeperYN LighthouseKeeperYN requested review from aluarius, m0ksem and rustem-nasyrov and removed request for aluarius and m0ksem February 23, 2023 16:10
@LighthouseKeeperYN LighthouseKeeperYN self-assigned this Feb 23, 2023
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool.

Found few issues:

  • No collapse animation (expand animation looks good)
  • Missing --expanded classes. It is a normal practice to add some background to an expanded row, people must have classes for it. For example:

image

Copy link
Contributor

@aluarius aluarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smthng happens for VaDataTable.new.demo.vue. It worked before, so, something goes wrong.

image

Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed demo a bit, so it looks a bit interesting:
image

Also, I moved back rowData to slot binds and added it to expandableRow.

@m0ksem m0ksem requested a review from aluarius March 1, 2023 11:06
@m0ksem m0ksem merged commit 9a7b7ad into epicmaxco:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaDataTable expandable row
3 participants