Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove units for height and width attributes; fix svg #3088

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix: remove units for height and width attributes; fix svg #3088

merged 1 commit into from
Feb 27, 2023

Conversation

rustem-nasyrov
Copy link
Collaborator

Close #3030

Description

  • According to the MDN docs for the img tag, removed units from height and width attributes.
  • Removed public path from svg path'.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@rustem-nasyrov rustem-nasyrov added the docs packages/docs label Feb 27, 2023
@rustem-nasyrov rustem-nasyrov self-assigned this Feb 27, 2023
@rustem-nasyrov rustem-nasyrov merged commit 58a67f7 into epicmaxco:develop Feb 27, 2023
@rustem-nasyrov rustem-nasyrov deleted the fix/docs-images branch February 27, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluarius aluarius aluarius approved these changes

@m0ksem m0ksem Awaiting requested review from m0ksem

Assignees

@rustem-nasyrov rustem-nasyrov

Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images are broken in dev mode....
2 participants
@rustem-nasyrov @aluarius