[#2864] va-select hovered position fix
#3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustem-nasyrov
requested changes
Mar 7, 2023
| return findNextActiveOption(currentOptionIndex.value - 1, true) | ||
| } | ||
|
|
||
| return undefined |
There was a problem hiding this comment.
Redundant undefined.
There was a problem hiding this comment.
It's not redundant -> eslint rules forces computed to have obvious return value.
Issue with 0 not related to this pr, will move it separately.
There was a problem hiding this comment.
How about null. It is not undefined, it is empty.
There was a problem hiding this comment.
It's not empty, it doesn't exist, undefined. Moreover, findNextActiveOption may return undefined if find method will find nothing. I don't think it's a good case to have one computed to return both null and undefined in same situations.
rustem-nasyrov
approved these changes
Mar 7, 2023
# Conflicts: # packages/ui/src/components/va-select/VaSelect.vue
m0ksem
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2964
Description
selectedTopShownstate after selection loses her hovered state, it goes to the previous option;Need QA, expecially of keyboard navigation.
Types of changes