Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with rating component #3192

Merged
merged 4 commits into from
Mar 20, 2023
Merged

fix: issues with rating component #3192

merged 4 commits into from
Mar 20, 2023

Conversation

kushich
Copy link
Member

@kushich kushich commented Mar 17, 2023

closes #3191

Description

  • set limit for min and max values by using keyboard arrows
  • fix aria-label attribute

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@kushich kushich requested a review from rustem-nasyrov March 17, 2023 11:59
rustem-nasyrov
rustem-nasyrov requested changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't set value to zero.
image

@kushich
Copy link
Member Author

kushich commented Mar 20, 2023

@rustem-nasyrov but there is the point, arrows have the similar functionality with mouse, we can set value to zero only if we provided clearable prop

@kushich kushich requested a review from rustem-nasyrov March 20, 2023 07:05
@kushich kushich merged commit e6e851f into epicmaxco:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VaRating component issues
2 participants
@kushich @rustem-nasyrov