-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add continuous counter update to VaCounter close #2108 #3247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: elements with multiple attributes should span multiple lines, with one attribute per line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks! Will do QA later. Try to move logic outside this component to composables. We likely will use it for other components like Carousel, Tabs, etc.
Lmk if you need help with this.
Hey, @Skander999. Composable looks good, thanks! I simplified it a bit using our existing utility composables like useEvent, useTemplateRef and removed your old implementation in VaCounter, so logic implemented in composable now, not in component. |
@RVitaly1978, check how your unnecessary refactoring impact other's PR- it was beautiful until I merged develop here to resolve conflicts :) Also, waiting for your review here, and we're ready to merge. |
Thank you for your feedback @m0ksem ! |
* Continous update of the counter when keep clicked * Refactor elements to span multiple lines with one attribute per line * Refactor: Moved logic to compostables * chore: eslint fixes * chore: refactor useLongPress composable * fix(counter): correctly use useLongPress composable * fix(counter): add long-press-delay prop --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>
Description
This PR adds a feature to the counter component in Vuestic UI that allows the counter to continuously update when the user keeps the button pressed instead of updating only once. close #2108
Markup:
Relevant code