Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): added source maps generation for css v-bind fix plugin #3302

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix(build): added source maps generation for css v-bind fix plugin #3302

merged 1 commit into from
Apr 11, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Apr 5, 2023 •
edited
Loading

👿

closes #3232

Mostly fix for #3263, this PR makes v-bind work with multi root node templates, so VaDatePickerCell works.

@m0ksem m0ksem requested a review from rustem-nasyrov April 5, 2023 14:54
@m0ksem m0ksem self-assigned this Apr 5, 2023
@m0ksem m0ksem marked this pull request as ready for review April 5, 2023 14:54
@m0ksem m0ksem added the build Build process label Apr 5, 2023
m0ksem
m0ksem commented Apr 11, 2023
View reviewed changes
Copy link
Collaborator Author

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add comments (vue doens't work well with css variables on SSR, so we remove vue approach, an use ours)
  • Follow up (maybe new issue where we want to fix this in vue.js itself)

@m0ksem m0ksem merged commit 15e707c into epicmaxco:develop Apr 11, 2023
@m0ksem m0ksem mentioned this pull request Apr 11, 2023
Closed
m0ksem added a commit that referenced this pull request Apr 12, 2023
@m0ksem
fix(build): added source maps generation for css v-bind fix plugin (#…
051987a 
…3302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov Awaiting requested review from rustem-nasyrov

Assignees

@m0ksem m0ksem

Labels
build Build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build sourcemaps for ui and docs
1 participant
@m0ksem