Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/layout #3382

Merged
merged 11 commits into from
Jul 20, 2023
Merged

Feat/layout #3382

merged 11 commits into from
Jul 20, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Apr 28, 2023 •
edited
Loading

closes #1430

Features:

  • New component: VaLayout
  • top, bottom, left, right slots
  • order
  • animations support
  • absolute areas
  • mobile friendly
  • docs and examples

Default:
image

Order:
image

Absolute:
image

@m0ksem m0ksem self-assigned this Apr 28, 2023
@m0ksem m0ksem marked this pull request as ready for review July 9, 2023 15:26
@m0ksem m0ksem added docs packages/docs component Is a new component or part of existing one labels Jul 9, 2023
@m0ksem m0ksem requested a review from zvenigorodskaia July 9, 2023 17:24
@asvae asvae self-requested a review July 10, 2023 10:33
asvae
asvae reviewed Jul 10, 2023
View reviewed changes
packages/docs/page-config/ui-elements/layout/examples/Absolute.vue
<template #left>
<VaButton @click="showSidebar = !showSidebar" :icon="showSidebar ? 'menu_open' : 'menu'" />
</template>
<h4>LOGO</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should improve default example a bit. Hamburger icon should stay left on mobile.

image

asvae
asvae reviewed Jul 10, 2023
View reviewed changes
packages/docs/page-config/navigationRoutes.ts
{
category: 'Layout',
name: 'layout',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to add a couple of examples at the beginning, similarly to https://www.naiveui.com/en-US/os-theme/components/layout

It seems to me that ready layout is something the user would hope to bring back from docs.

asvae
asvae approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like that component is very minimal and easy to support.

props are not very intuitive, but it doesn't seem there is a way to improve that without a lot of examples / builder / extremely heavy component.

@asvae asvae merged commit 26948d6 into epicmaxco:develop Jul 20, 2023
@m0ksem m0ksem mentioned this pull request Jul 20, 2023
Closed
asvae pushed a commit to asvae/vuestic-ui that referenced this pull request Jul 20, 2023
@m0ksem @asvae
Revert "Feat/layout (epicmaxco#3382)"
cb224c3 
This reverts commit 26948d6.
asvae pushed a commit that referenced this pull request Jul 21, 2023
@m0ksem @asvae
Revert "Feat/layout (#3382)"
5277538 
This reverts commit 26948d6.
@m0ksem m0ksem mentioned this pull request Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae approved these changes

@zvenigorodskaia zvenigorodskaia Awaiting requested review from zvenigorodskaia

Assignees

@m0ksem m0ksem

Labels
component Is a new component or part of existing one docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Component: Page layout
2 participants
@m0ksem @asvae