-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support configure css variables generation location #3466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is look great.
We also need to handle it in nuxt/packages
. So instead of htmlAttrs we need to use content in useHead
. Otherwise both style tag and html attribute will be rendered.
No, html arribute is default. It just adds an optional configuration so that we can choose to transfer the color variables to a new style tag. |
I added some changes related to nuxt, but there is still a small bug. We render Will make a different issue for that. Looks awesome for SPA btw. Thanks! |
@shiina7, would you like to write docs for this feature under Services/ColorConfig? |
@shiina7 does it make any point to keep previous solution and not just keep yours? (and get rid of |
@asvae my first point is to expend it, not change. beacuse I think that I can't decide it, but you(author) can. If you think it's okay to just keep the new style tag, I'm glad to change it. |
Perhap someone needs this option and we can keep, If we want keep new tag we can set the |
I think we can remove previous solution. It was made asap and not documented, so we can just drop it. |
Okay, got it. It's will be change it tomorrow. |
This reverts commit 7581447.
…ated to style tag
@m0ksem @asvae I removed the styleTag option and only support generated css variables to style tag now. review it please, maybe it can be included in the next version. |
It's actually great to have in context of 1.7.0, as if something would break - users would probably somewhat expect it :D. Thanks @shiina7 🤗 |
support configure css variables generation location
Description
closes #3442
support configure css variables generation location, root element(html) or new style tag.
Types of changes