Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: props descriptions #3516

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: props descriptions #3516

merged 2 commits into from
Jun 21, 2023

Conversation

asvae
Copy link
Member

@asvae asvae commented Jun 20, 2023 •
edited
Loading

After translations removal all descriptions disappeared. I tried to fix it, but typing is somewhat broken with a number of loose ends.

So @m0ksem maybe you have a context to finish this one without much of a trouble?

That's mission critical for release!

image

Note:

image Here we define meta as an object, but we get array in the prop!

@m0ksem m0ksem marked this pull request as ready for review June 21, 2023 07:37
m0ksem
m0ksem approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to combine api description and manual options into one config file, but it looks OK for now.

@asvae
Copy link
Member Author

asvae commented Jun 21, 2023

I'd like to combine api description and manual options into one config file, but it looks OK for now.

Could you create an issue for that?

@m0ksem m0ksem mentioned this pull request Jun 21, 2023
Closed
@asvae
Copy link
Member Author

asvae commented Jun 21, 2023

Thanks!

@asvae asvae merged commit ddb24da into develop Jun 21, 2023
@asvae asvae deleted the fix/props-descriptions branch June 21, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvae @m0ksem