fix(ui): select, date-input, time-input keyboard navigation #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvae
requested changes
Jun 22, 2023
pogrib0k
suggested changes
Jul 1, 2023
There was a problem hiding this comment.
I looked it up like everything is ok.
But DateInput allows focus outside the component, so sometimes something like this happens:
Also, because of this, I can open many "dropdowns" at the same time (see screenshot), and when I press ESC they all close at the same time.
m0ksem
force-pushed
the
fix/dropdownable-keyboard-navigation
branch
from
c66624c to
e5ca6d9
Compare
ilearnjs
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was impossible to open select, date-input, time-input with space and enter for some reason.
closes #3533
closes #3530