Added Linear stepper and custom step actions #3641
Conversation
|
The whitespace changes where made automatically by prettier |
I understand it. But better do not use any formatter, so it is easier to review the code... Maybe we should have a standardized Prettier config, actually. |
…s://github.com/Bond-Addict/vuestic-ui into feat/stepper-with-save-actions-and-linear-mode
|
I added an invalid class for the stepper step too. |
|
The only conflict I have is the yarn lock. Should I do the same as the package.lock and delete the yarn.lock? |
I can handle it before merge. |
…tended. Steps must be manually completed if linear prop is provided.
m0ksem
force-pushed
the
feat/stepper-with-save-actions-and-linear-mode
branch
from
28c990e to
9241045
Compare
|
@Bond-Addict, I made demos less confusing and also added few extra features. Please, review if I did something wrong. Otherwise, it looks good for me. The last step is to update docs demo if you're ok with changes I made. |
I looks great dude. Thanks for the assist! Just for my understanding, what was I doing wrong with the button color part? Was there some vue fundamental I was messing up? I'll get the docs updated as soon as possible. |
There was a bug on line https://github.com/epicmaxco/vuestic-ui/pull/3641/files#diff-330631d4f7a4d81d8d3d14e31f746d0e1c148d4e5bb9c063913166c6a7b5addeL50. Because it wasn't computed, color wasn't updating if you change it later... So it always was primary. |
Ah okay. I had tried to use a computed earlier but there must have been something messed up. I'm glad to know I was on the right track though. I'll try and get the docs update Monday morning. Have a good weekend! |
|
@m0ksem Can you explain the correct steps to get the docs to run? I've gotten it to generate one time, but I have no idea how I did it. Once I can get them to run I'll get the docs updated. I've been looking at the contribution docs, but cant seem to figure it out. I might be doing something wrong, but I cant get |
Maybe you need to reinstall deps. Run |
|
I this error normal?
|
Nope. Try to clean node_modules/.cache or .nuxt folder. Likely something is cached. Or try yarn --force. |
I'll try clearing cache and nuxt folder but I have tried a couple times to run yarn --force |
@m0ksem I'm unable to get the docs updated due to this issue. In light of this, would you be able to update the doc? My project is dependent on this feature so its at a stand standstill. |
Yeah, sure. I wanted to handle the rest of pr before next release and I hope @asvae gonna have some time to review it. |
Awesome, thank you so much. I appreciate the continued support. I'll try and ensure the next change goes a bit smoother. |
…h-save-actions-and-linear-mode
|
@m0ksem How do I resolve your requested change? The pr is currently failing the "Changes requested" precheck. |
|
@Bond-Addict hey, I actually coded it quickly myself (hope you don't mind the intrusion 🙏). I can merge it no problems. :) |
I don't mind at all. I appreciate the assist from yall to get this feature in. I look forward to seeing the future optimizations as I'm still learning Vue and want to learn the best practices 😃 |
Hi, we good. I'm not sure if you saw that I pinged you in Discord, so you could get this feature released in an experimental build. We're currently in a process to move dev discussions to discord, where we can communicate faster with contributors, help them and ship code faster. If you were interested in real-time communication instead of GitHub comments, you're welcome!
|
Ah okay I must have missed that message. Thanks for all the assistance getting this out. You rock! 😄 |
* Added Linear stepper and custom step actions * Reverted prettier changes and removed package-lock * Wip for pr comments * Passing form to stepper wip * Trying to pass ref as a nested object to protect against unwrapping * fix(va-stepper): register va-form component in demos * fix(va-stepper): memory leak using useForm in methods * fix(va-stepper): remove extra FormRef type * Working on form ref reactivity * Cleanup * Set prop default and add another field to demo * Set navigation buttons disabled if invalid * Set invalid color on invalid form * Package updates * Docs update * Changed stepper to not handle validating form. Linear does work as intended. Steps must be manually completed if linear prop is provided. * Cleanup * Whitespace fixes * More whitespace fixes * More whitespace fixes * More whitespace fixes and doc updates * More whitespace fixes * More whitespace fixes * More whitespace fixes * More whitespace fixes * Whitespace * Whitespace * Whitespace * Whitespace * Whitespace * Whitespace * chore: update yarn lock * Suggestions Pt.1 * Trying to set danger if error exists * Trying to fix error color. It seems like it should work, but the step button isnt reacting to change. * fix(stepper): fix: refactor stepper validation * feat(stepper): added computed error * docs(stepper): add linear docs demo * chore: beforeSave -> beforeLeave --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> Co-authored-by: Yauheni Prakopchyk <yauheni.prakopchyk@epicmax.co>
Description
closes #3635
This change will introduce two useful features:
Linear Mode- This forces form validation to be valid before navigation will occur.
Custom step actions- This add a
saveproperty on the Step interface. This allows the user to specify save actions for each step. This goes hand in hand with linear because it makes it where the stepper can be treated like a true wizard ensuring a previous step has completed successfully. Example: You create a user on step 1 and then you assign multiple roles on step 2. If the user didn't exist when you get to step 2 you wouldn't be able to add the roles. You won't navigate to the desired step unless the save function succeeds.Required validator- Adds a required function that accepts a custom error message but provides a default one.
Types of changes