Stories rework: VaAvatar #3795
Merged
Stories rework: VaAvatar #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvae
approved these changes
Sep 5, 2023
| components: { VaAvatar }, | ||
| template: '<VaAvatar/>', | ||
| template: ` | ||
| <VaAvatar> |
There was a problem hiding this comment.
Let's use avatar with image as default example.
| export const Color = () => ({ | ||
| components: { VaAvatar }, | ||
| template: ` | ||
| [warning] |
There was a problem hiding this comment.
Doesn't seem to be relevant. Same in other places.
Suggested change
| [warning] |
| export const Size = () => ({ | ||
| components: { VaAvatar }, | ||
| template: ` | ||
| [smal] |
There was a problem hiding this comment.
Here small/medium etc is fine, as we have several options.
| export const FontSize = () => ({ | ||
| components: { VaAvatar }, | ||
| template: ` | ||
| [0.75rem] |
| <VaAvatar | ||
| src="https://randomuser.me/api/portraits/women/5.jpg" | ||
| alt="image" | ||
| > |
|
|
||
| export const FallbackText = () => ({ | ||
| components: { VaAvatar }, | ||
| template: '<VaAvatar src="https://not-exist" fallbackText="Fallback"/>', |
There was a problem hiding this comment.
Suggested change
| template: '<VaAvatar src="https://not-exist" fallbackText="Fallback"/>', | |
| template: '<VaAvatar src="https://not-exist" fallbackText="Text"/>', |
Current version looks like bug to me.
| export const FallbackRender = () => ({ | ||
| components: { VaAvatar }, | ||
| methods: { | ||
| FallbackRender: () => h('b', { |
There was a problem hiding this comment.
Suggested change
| FallbackRender: () => h('b', { | |
| fallbackRender: () => h('b', { |
Methods start from lowercase.
| }, | ||
| }, 'Text'), | ||
| }, | ||
| template: '<VaAvatar src="https://not-exist" :fallbackRender="FallbackRender"/>', |
There was a problem hiding this comment.
Suggested change
| template: '<VaAvatar src="https://not-exist" :fallbackRender="FallbackRender"/>', | |
| template: '<VaAvatar src="https://not-exist" :fallbackRender="fallbackRender"/>', |
m0ksem
pushed a commit
that referenced
this pull request
Sep 12, 2023
* va-avatar stories * va-avatar stories * va-avatar stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar stories