Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story rework: VaViewer #3883

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Story rework: VaViewer #3883

merged 3 commits into from
Sep 21, 2023

Conversation

xiongmao86
Copy link
Contributor

@xiongmao86 xiongmao86 commented Sep 18, 2023 •
edited
Loading

Story rework of VaViewer
Part of #3676.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@xiongmao86
Copy link
Contributor Author

Ah, why is the chromatic test is not run? I have checked in local storybook and the one of the interaction test is not passed.

@asvae
Copy link
Member

asvae commented Sep 21, 2023

@xiongmao86 hey,

We actually disabled chromatic autotest for all branches (took too many screenshots out of chromatic plan).

You still can trigger chromatic manually (yarn chromatic from packages/ui folder), then link it here if you want.

asvae
asvae approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I added a tweak for the failing test.

@asvae asvae merged commit 2e5af49 into epicmaxco:develop Sep 21, 2023
1 check passed
@xiongmao86 xiongmao86 deleted the fix/va-viewer-rework branch September 22, 2023 03:24
@xiongmao86
Copy link
Contributor Author

Thank you very much for helping me with this pr, @asvae.

@asvae asvae mentioned this pull request Sep 23, 2023
Open
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiongmao86 @asvae