Allow custom strings in i18n config (#4243) #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fsss126
changed the title
m0ksem
approved these changes
May 7, 2024
| @@ -21,17 +35,17 @@ export const useTranslation = () => { | |||
|
|
|||
| return { | |||
There was a problem hiding this comment.
Can we add here getCurrentInstance, find $i18n and try to $t. User may have i18n module installed and we can find value from their config, instead of our. I'd say, i18n confirm have priority over our translations config. But, I think we also need require user to prefix translations for vuestic. So it is va:cancel, not just cancel. We don't react if user changed language with i18n config - that's the main problem.
There was a problem hiding this comment.
Found it here: https://github.com/epicmaxco/vuestic-ui/pull/4256/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4243
Description
Allowed custom strings and improved type checking and autocompletion in ide for keys
Also added ability to have autocompletion know about user-added keys through module augmentation
Types of changes