-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to resolve $t from vue global properties (#4244) #4256
Merged
m0ksem
merged 3 commits into
epicmaxco:develop
from
Fsss126:resolve-vue-i18n-translations
May 23, 2024
Merged
Try to resolve $t from vue global properties (#4244) #4256
m0ksem
merged 3 commits into
epicmaxco:develop
from
Fsss126:resolve-vue-i18n-translations
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fsss126
changed the title
Try to resolve $t from vue global properties #4244
Try to resolve $t from vue global properties (closes #4244)
May 6, 2024
Fsss126
changed the title
Try to resolve $t from vue global properties (closes #4244)
Try to resolve $t from vue global properties (#4244)
May 6, 2024
m0ksem
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, resolve conflicts and we're good to go.
packages/docs/page-config/services/i18n/code/vue-i18n-runtime.ts
Outdated
Show resolved
Hide resolved
Fsss126
force-pushed
the
resolve-vue-i18n-translations
branch
from
May 8, 2024 21:24
f42d3e2
to
5b11bd3
Compare
m0ksem
reviewed
May 23, 2024
packages/docs/page-config/services/i18n/code/vue-i18n-runtime.ts
Outdated
Show resolved
Hide resolved
m0ksem
reviewed
May 23, 2024
m0ksem
approved these changes
May 23, 2024
Fsss126
added a commit
that referenced
this pull request
May 25, 2024
* fix: tab animation when link * fix(tabs): what for router link changes * feat(data-table): add no-data slot * fix(counter/#4281): disable button in readonly VaCounter * fix(file-upload/#4282): add file incorrect i18n key * Fixed scoped class on modal (#4274) * Try to resolve $t from vue global properties (#4244) (#4256) * Try to resolve $t from vue global properties #4244 * fix(docs/i18n): move back vuestic key in example * docs(i18n): remove extra steps in vue-i18n --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> * Let VaDateInput accept a null value (#4169) * Allow a user to have a null date input. Devs will have to handle validation as they normal would with other controlls. * Updated to use props.clearValue and merged develop back in * fix(date-input): allow null value --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> * fix(i18n): use custom values when translating props * fix(data-table/story): fix correct no filter data story * Fixed code audit modal on mobile --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> Co-authored-by: Bond-Addict <117455332+Bond-Addict@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4244
Description
Implemented feature and updated docs
Types of changes