Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to resolve $t from vue global properties (#4244) #4256

Merged
merged 3 commits into from
May 23, 2024

Conversation

Fsss126
Copy link
Contributor

@Fsss126 Fsss126 commented May 6, 2024

closes #4244

Description

Implemented feature and updated docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@Fsss126 Fsss126 changed the title Try to resolve $t from vue global properties #4244 Try to resolve $t from vue global properties (closes #4244) May 6, 2024
@Fsss126 Fsss126 changed the title Try to resolve $t from vue global properties (closes #4244) Try to resolve $t from vue global properties (#4244) May 6, 2024
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve conflicts and we're good to go.

packages/docs/page-config/services/i18n/index.ts Outdated Show resolved Hide resolved
@Fsss126 Fsss126 force-pushed the resolve-vue-i18n-translations branch from f42d3e2 to 5b11bd3 Compare May 8, 2024 21:24
@m0ksem m0ksem merged commit 083a39c into epicmaxco:develop May 23, 2024
1 check passed
Fsss126 added a commit that referenced this pull request May 25, 2024
* fix: tab animation when link

* fix(tabs): what for router link changes

* feat(data-table): add no-data slot

* fix(counter/#4281): disable button in readonly VaCounter

* fix(file-upload/#4282): add file incorrect i18n key

* Fixed scoped class on modal (#4274)

* Try to resolve $t from vue global properties (#4244) (#4256)

* Try to resolve $t from vue global properties #4244

* fix(docs/i18n): move back vuestic key in example

* docs(i18n): remove extra steps in vue-i18n

---------

Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>

* Let VaDateInput accept a null value (#4169)

* Allow a user to have a null date input. Devs will have to handle validation as they normal would with other controlls.

* Updated to use props.clearValue and merged develop back in

* fix(date-input): allow null value

---------

Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>

* fix(i18n): use custom values when translating props

* fix(data-table/story): fix correct no filter data story

* Fixed code audit modal on mobile

---------

Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>
Co-authored-by: Bond-Addict <117455332+Bond-Addict@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(i18n): try to resolve $t from vue global properties
2 participants