Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#4294/input required mark and switch left label #4295

Conversation

untael
Copy link
Member

@untael untael commented May 30, 2024

Closes #4294

Description

Fixes alignment issue with VaSwitch if label is left aligned
Fixes VaInputLabel required mark size to not enlarge container size

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@Bond-Addict
Copy link
Contributor

I can't get codespaces to run the storybook correctly (Throws a ton of looping 404's) but I just applied these changes locally in my scss file and these work for me :)

@Bond-Addict
Copy link
Contributor

image

@m0ksem m0ksem merged commit 5f6bda5 into epicmaxco:develop Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When adding required-mark to an input it causes the input to shift causing misalignment with other inputs.
3 participants