Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that the log does not stop when config=-1. #33

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

hongran
Copy link

@hongran hongran commented Jul 24, 2024

I added an if structure in the worker loop and it checks the config. If config=-1, continue the loop without creating a log.
This fix is tested.

@anjohnson
Copy link
Member

This is a fix for #31, but it doesn't short-circuit or de-register the trap-write routine, so the performance of records whose puts are configured to be logged won't change by much if the config is changed at runtime. The field values before and after each put are still queued and sent to the lower-priority logger thread, it just discards them.

Re-running the vs2019/static test which looks like it failed due to GitHub CI infrastructure reasons.

@anjohnson anjohnson merged commit f4b2745 into epics-modules:master Jul 25, 2024
5 checks passed
anjohnson added a commit that referenced this pull request Jul 25, 2024
anjohnson added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants